chiptune.js ➔ afterLoad - Code Metrics - Inspection of "organize hierarchy and add configuration system" - typicalname0/4grounds - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#20)

by Maxwell

created 2020-08-17 02:26 UTC

chiptune.js ➔ afterLoad A

↳ Parent: static/js/chiptune.js

Complexity

Conditions

Size

Total Lines	6
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
dl	0
loc	6
rs	10
c	0
b	0
f	0

window["libopenmpt"] = {};
libopenmpt.locateFile = function (filename) {

    return "//cdn.jsdelivr.net/gh/deskjet/chiptune2.js@master/" + filename;
};
libopenmpt.onRuntimeInitialized = function () {
    var player;

    function init() {
        if (player == undefined) {

            player = new ChiptuneJsPlayer(new ChiptuneJsConfig(-1));

        }
        else {
            player.stop();
            playPauseButton();
        }
    }

    function setMetadata(filename) {
        var metadata = player.metadata();
        if (metadata["title"] != "") {
            document.getElementById("title").innerHTML = metadata["title"];
        }
        else {
            document.getElementById("title").innerHTML = filename;
        }

        if (metadata["artist"] != "") {
            document.getElementById("artist").innerHTML = "<br />" + metadata["artist"];
        }
        else {
            document.getElementById("artist").innerHTML = "";
        }
    }

    function afterLoad(path, buffer) {
        document.querySelectorAll("#pitch,#tempo").forEach(e => e.value = 1);
        player.play(buffer);
        setMetadata(path);
        pausePauseButton();
    }

    function loadURL(path) {
        init();
        player.load(path, afterLoad.bind(this, path));

    }

    function pauseButton() {
        player.togglePause();
        switchPauseButton();
    }

    function switchPauseButton() {
        var button = document.getElementById("pause")
        if (button) {
            button.id = "play_tmp";
        }
        button = document.getElementById("play")
        if (button) {
            button.id = "pause";
        }
        button = document.getElementById("play_tmp")
        if (button) {
            button.id = "play";
        }
    }

    function playPauseButton() {
        var button = document.getElementById("pause")
        if (button) {
            button.id = "play";
        }
    }

    function pausePauseButton() {
        var button = document.getElementById("play")
        if (button) {
            button.id = "pause";
        }
    }

    var fileaccess = document.querySelector("*");
    fileaccess.ondrop = function (e) {
        e.preventDefault();
        var file = e.dataTransfer.files[0];
        init();

        player.load(file, afterLoad.bind(this, path));

    }

    fileaccess.ondragenter = function (e) { e.preventDefault(); }
    fileaccess.ondragover = function (e) { e.preventDefault(); }

    document.querySelectorAll(".song").forEach(function (e) {
        e.addEventListener("click", function (evt) {
            modurl = evt.target.getAttribute("data-modurl");

            loadURL(modurl);
        }, false);
    });

    document.querySelector("input[name=files]").addEventListener("change", function (evt) {
        loadURL(evt.target.files[0]);
    });

    document.querySelector("input[name=submiturl]").addEventListener("click", function () {
        var exturl = document.querySelector("input[name=exturl]");
        modurl = exturl.value;

        loadURL(modurl);
        exturl.value = null;
    });

    document.querySelector("#play").addEventListener("click", pauseButton, false);

    document.querySelector("#pitch").addEventListener("input", function (e) {
        player.module_ctl_set("play.pitch_factor", e.target.value.toString());
    }, false);

    document.querySelector("#tempo").addEventListener("input", function (e) {
        player.module_ctl_set("play.tempo_factor", e.target.value.toString());
    }, false);
};


1			window["libopenmpt"] = {};
2			libopenmpt.locateFile = function (filename) {
			0 ignored issues – show Bug introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The variable `libopenmpt` seems to be never declared. If this is a global, consider adding a `/** global: libopenmpt */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
3			return "//cdn.jsdelivr.net/gh/deskjet/chiptune2.js@master/" + filename;
4			};
5			libopenmpt.onRuntimeInitialized = function () {
6			var player;
7
8			function init() {
9			if (player == undefined) {
			0 ignored issues – show Best Practice introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report Comparing `player` to `undefined` using the `==` operator is not safe. Consider using `===` instead. Loading history...
10			player = new ChiptuneJsPlayer(new ChiptuneJsConfig(-1));
			0 ignored issues – show Bug introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The variable `ChiptuneJsPlayer` seems to be never declared. If this is a global, consider adding a `/** global: ChiptuneJsPlayer /` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Bug introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The variable `ChiptuneJsConfig` seems to be never declared. If this is a global, consider adding a `/* global: ChiptuneJsConfig */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
11			}
12			else {
13			player.stop();
14			playPauseButton();
15			}
16			}
17
18			function setMetadata(filename) {
19			var metadata = player.metadata();
20			if (metadata["title"] != "") {
21			document.getElementById("title").innerHTML = metadata["title"];
22			}
23			else {
24			document.getElementById("title").innerHTML = filename;
25			}
26
27			if (metadata["artist"] != "") {
28			document.getElementById("artist").innerHTML = "<br />" + metadata["artist"];
29			}
30			else {
31			document.getElementById("artist").innerHTML = "";
32			}
33			}
34
35			function afterLoad(path, buffer) {
36			document.querySelectorAll("#pitch,#tempo").forEach(e => e.value = 1);
37			player.play(buffer);
38			setMetadata(path);
39			pausePauseButton();
40			}
41
42			function loadURL(path) {
43			init();
44			player.load(path, afterLoad.bind(this, path));
			0 ignored issues – show Unused Code introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The call to `bind` does not seem necessary since the function `afterLoad` declared on line `35` does not use `this`. Loading history...
45			}
46
47			function pauseButton() {
48			player.togglePause();
49			switchPauseButton();
50			}
51
52			function switchPauseButton() {
53			var button = document.getElementById("pause")
54			if (button) {
55			button.id = "play_tmp";
56			}
57			button = document.getElementById("play")
58			if (button) {
59			button.id = "pause";
60			}
61			button = document.getElementById("play_tmp")
62			if (button) {
63			button.id = "play";
64			}
65			}
66
67			function playPauseButton() {
68			var button = document.getElementById("pause")
69			if (button) {
70			button.id = "play";
71			}
72			}
73
74			function pausePauseButton() {
75			var button = document.getElementById("play")
76			if (button) {
77			button.id = "pause";
78			}
79			}
80
81			var fileaccess = document.querySelector("*");
82			fileaccess.ondrop = function (e) {
83			e.preventDefault();
84			var file = e.dataTransfer.files[0];
85			init();
86
87			player.load(file, afterLoad.bind(this, path));
			0 ignored issues – show Unused Code introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The call to `bind` does not seem necessary since the function `afterLoad` declared on line `35` does not use `this`. Loading history... Bug introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The variable `path` seems to be never declared. If this is a global, consider adding a `/** global: path */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
88			}
89
90			fileaccess.ondragenter = function (e) { e.preventDefault(); }
91			fileaccess.ondragover = function (e) { e.preventDefault(); }
92
93			document.querySelectorAll(".song").forEach(function (e) {
94			e.addEventListener("click", function (evt) {
95			modurl = evt.target.getAttribute("data-modurl");
			0 ignored issues – show Bug introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The variable `modurl` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.modurl`. Loading history...
96			loadURL(modurl);
97			}, false);
98			});
99
100			document.querySelector("input[name=files]").addEventListener("change", function (evt) {
101			loadURL(evt.target.files[0]);
102			});
103
104			document.querySelector("input[name=submiturl]").addEventListener("click", function () {
105			var exturl = document.querySelector("input[name=exturl]");
106			modurl = exturl.value;
			0 ignored issues – show Bug introduced 2020-08-17 01:16 UTC by Report Bug Copy Issue Report The variable `modurl` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.modurl`. Loading history...
107			loadURL(modurl);
108			exturl.value = null;
109			});
110
111			document.querySelector("#play").addEventListener("click", pauseButton, false);
112
113			document.querySelector("#pitch").addEventListener("input", function (e) {
114			player.module_ctl_set("play.pitch_factor", e.target.value.toString());
115			}, false);
116
117			document.querySelector("#tempo").addEventListener("input", function (e) {
118			player.module_ctl_set("play.tempo_factor", e.target.value.toString());
119			}, false);
120			};
121

typicalname0 / 4grounds

Pull Request — master (#20)

chiptune.js ➔ afterLoad A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like